• PhilipTheBucket@ponder.cat
    link
    fedilink
    English
    arrow-up
    9
    ·
    19 days ago
    1. This is nothing to do with ActivityPub. It’s to do with Mastodon’s custom implementation of “private” posts.
    2. Making it extremely clear to everyone that random server software can expose Mastodon’s “private” posts is absolutely the right way to handle disclosure here. Dan didn’t even try to do that, he just fixed the bug, but if he had made a big post saying “hey this is not my fault Mastodon private posts are not private, here’s full explanation about what’s going on” I think that would have been completely fine. This is not a “vulnerability” in the traditional sense like a buffer overflow, it’s just a design flaw in Mastodon which other softwares are by convention agreeing to cater to. I think the culture of security (and the level of clue in general) in the Fediverse has wandered into territory where “let’s all pretend that these posts are secure and get mad at anyone who reveals that they are not” is widely accepted now, but that doesn’t make it right.
    • troed@fedia.io
      link
      fedilink
      arrow-up
      3
      ·
      19 days ago

      It has everything to do with ActivityPub since if you follow that protocol strictly you will cause this behavior. It still doesn’t change that Dansup was told that this caused Bad Things™ and yet he didn’t follow normal procedure in how you handle it.

      Vulnerabilities don’t need to be buffer overflows.

      /cybersec researcher

      • PhilipTheBucket@ponder.cat
        link
        fedilink
        English
        arrow-up
        4
        ·
        edit-2
        19 days ago

        It has everything to do with ActivityPub since if you follow that protocol strictly you will cause this behavior.

        Absolutely not. Which part of the spec? I linked up there to quite a thorough explanation of what the spec does and doesn’t dictate in this area, and how Mastodon chooses to behave in its implementation. What part of my explanation did I get wrong? Are they violating 5.1, 5.2, 7.1, some other part? How?

        /cybersec researcher

        I do not believe you. “I’m sending things out which need to be handled carefully in a protocol-nonstandard way by the recipient server software (which could be literally anything), or else my user’s private posts will be exposed. If someone talks about that situation and lets people know what’s going on, that’s irresponsible disclosure.”

        If you actually are a cybersec researcher, you are bad at your job.

          • PhilipTheBucket@ponder.cat
            link
            fedilink
            English
            arrow-up
            3
            ·
            19 days ago

            Okay. What part of the spec did Pixelfed violate? Where in the spec is Mastodon’s implementation of private posts justified?

            • troed@fedia.io
              link
              fedilink
              arrow-up
              2
              ·
              19 days ago

              Read more, post less. I’ve said nothing about any spec violation. That’s not relevant.

              • PhilipTheBucket@ponder.cat
                link
                fedilink
                English
                arrow-up
                2
                ·
                edit-2
                19 days ago

                I’ve said nothing about any spec violation. That’s not relevant.

                It has everything to do with ActivityPub since if you follow that protocol strictly you will cause this behavior.

                That’s what I was going by. I guess I could re-read this now and interpret “this behavior” as Pixelfed’s side, instead of Mastodon’s side as I initially read it, and decide that you are agreeing with me that Mastodon’s behavior was (and is) out of spec? Do I have that right?

                It still doesn’t change that Dansup was told that this caused Bad Things™ and yet he didn’t follow normal procedure in how you handle it.

                It is normal procedure to fix a bug when you are notified about it.

                The design flaw in Mastodon that managed to bite Pixelfed in this situation still exists. People were writing about it back in 2017 when this was all being first implemented. The idea that “normal procedure” needs to include keeping it a secret that Mastodon’s “private” statuses can be exposed by any server software that doesn’t handle them in the way that’s expected, is 100% wrong.

                I’ll rephrase what I said earlier: Since you’re a security researcher, and you apparently think Dan should have played into the idea of keeping it a secret that Mastodon’s private statuses are not secret by obfuscating the information about how he was fixing Pixelfed to more effectively hide them, you are bad at your job. In this instance. The fault lies with how private statuses are implemented, and nothing about that needs to be kept secret as would a normal vulnerability, during responsible disclosure. In fact, it is extremely harmful to let users believe that these privacy settings are anything other than vague recommendations, specifically because of the risk they will act accordingly and expose some of their private posts to the world. They should know exactly what’s going on with it, and Dan accidentally failing to keep that a secret is in no way causing bad things.

                • troed@fedia.io
                  link
                  fedilink
                  arrow-up
                  2
                  arrow-down
                  1
                  ·
                  19 days ago

                  You have absolutely no idea what “responsible” in “responsible disclosure” means :) It’s completely irrelevant how Mastodon has implemented private posts when it comes to how Dansup handled the issue, knowing what the effects were.

                  You don’t, when told of a vulnerability, handle it in a way that cause harm if it can be avoided.

                  • PhilipTheBucket@ponder.cat
                    link
                    fedilink
                    English
                    arrow-up
                    2
                    ·
                    19 days ago

                    Yeah, you said that stuff before and then you said it again. I do understand what your argument is here. I was trying a couple of different ways of explaining what I was saying in response, but it seems like it’s not working. Oh well.

    • irelephant [he/him]🍭@lemm.ee
      link
      fedilink
      English
      arrow-up
      2
      ·
      19 days ago

      Maybe I’m wrong, but shouldn’t posts only be insecure if they’re propagated to the insecure instance? Is any private post visible to people on servers that the poster doesn’t have followers on?
      Could I curl the uri of a post thats “private” and get the post’s content?

      • PhilipTheBucket@ponder.cat
        link
        fedilink
        English
        arrow-up
        3
        ·
        19 days ago

        Maybe I’m wrong, but shouldn’t posts only be insecure if they’re propagated to the insecure instance?

        “Insecure” in this case simply means any server that doesn’t implement Mastodon’s custom handling for “private” posts. With that definition, the answer to your question is yes. It has been mentioned by Mastodon people that this is a significant problem for the ability to actually keep these private posts private in the real world. The chance of it going wrong is small (depending on your follower count) but the potential for harm is very large. I would therefore go further, and say that it’s a very bad thing that Mastodon is telling people that these posts are “private” when the mechanism which is supposed to keep them private is so unreliable.

        https://marrus-sh.github.io/mastodon-info/everything-you-need-to-know-about-privacy-v1.3-020170427.html

        https://github.com/mastodon/mastodon/issues/712

        Is any private post visible to people on servers that the poster doesn’t have followers on?

        It is not. If you’re sufficiently careful with approving your followers, making sure that each of them is on an instance that’s going to handle private posts the way you expect, then you’re probably fine.

        Could I curl the uri of a post thats “private” and get the post’s content?

        If it’s been federated to an insecure server then yes. If not then I think no.

        • irelephant [he/him]🍭@lemm.ee
          link
          fedilink
          English
          arrow-up
          3
          ·
          19 days ago

          Mastodon really is the internet explorer of the fediverse.
          In any case, I don’t think its that bad. I would compare it to an email provider accidentially leaking messages. Still bad, but its not a reason to abandon email as a means of communication.
          We should encrypt posts, like diaspora does. Like how we should pgp encrypt emails, but no one will.

          also, I just checked myself, a random “private” post I made isn’t accessible over AP if I curl it unauthenticated. Running curl.exe https://calckey.world/notes/a63slz8j6l -H "Accept: application/activity+json" returns nothing, but replacing the uri with a public post does show it.
          An insecure server’s copy of the post isn’t accessible over AP, only the original post’s link should return anything.